Feat/717 Ensure unique filenames in eFormidling shipment

[bjorntore]

Avoid duplicated filenames in eFormidling shipment.

Related Issue(s)

• Input validation before creating an eFormidlings "shipment" #717

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

[ivarne]

Looks good, and great tests.

I added a few tests for the unique function, and had to make a smal change to ensure everything passes.

After writing the test I realised that it might be good to prefix attachments with filename arkivmelding with their data type.

[ivarne]

After writing the test I realised that it might be good to prefix attachments with filename arkivmelding with their data type.

I was thinking something like this to ensure that no files starts with arkivmelding... but gets renamed to {dataType}-arkivmelding...

        List<string> dataTypeIds = applicationMetadata
            .DataTypes.Select(x => x.Id)
            .Concat([eformidlingMetadataFilename.Substring(eformidlingMetadataFilename.IndexOf('.'))])
            .ToList();

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud