Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clean up imports by moving layoutset hooks from ux-editor to shared #13587

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Sep 20, 2024

Description

  • Three hooks where placed in ux-editor package, but was imported and used in several other packages. They where therefore moved to shared as they are shared between different packages.

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 20, 2024
@wrt95 wrt95 changed the title Clean up imports by moving layoutset hooks from ux-editor to shared feat: Clean up imports by moving layoutset hooks from ux-editor to shared Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (3c09043) to head (bb759bb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13587   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files        1498     1498           
  Lines       20470    20474    +4     
  Branches     2476     2476           
=======================================
+ Hits        19489    19493    +4     
  Misses        873      873           
  Partials      108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@wrt95 wrt95 added frontend and removed area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. labels Sep 24, 2024
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testet ok👍

@wrt95 wrt95 merged commit 715c09e into main Sep 24, 2024
17 checks passed
@wrt95 wrt95 deleted the Move-layouset-hooks-from-ux-editor-to-shared branch September 24, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants