Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add defaultValue from schema to EditBooleanValue component #13584

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Sep 19, 2024

Description

Ensure default boolean values that are true from boolean properties in component schemas is reflected as true in config panel by checking the switch using the default value if there is no value from the component.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 19, 2024
@standeren standeren added the kind/bug Used when there is a defect / something is not working as it should. label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (d8b9ac2) to head (20f1383).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13584      +/-   ##
==========================================
+ Coverage   95.21%   95.23%   +0.01%     
==========================================
  Files        1495     1495              
  Lines       20435    20434       -1     
  Branches     2471     2470       -1     
==========================================
+ Hits        19458    19461       +3     
+ Misses        872      868       -4     
  Partials      105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the fix/datepicker-timstamp-should-be-default-true branch 2 times, most recently from d264a7f to 4eb06a4 Compare September 19, 2024 13:56
@framitdavid
Copy link
Collaborator

review started

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🪨 But is this a bug that we should fix for v3 apps as well? 🤔

@standeren
Copy link
Contributor Author

Nice work! 🪨 But is this a bug that we should fix for v3 apps as well? 🤔

Good point! I'll have a look! 💪

@standeren standeren force-pushed the fix/datepicker-timstamp-should-be-default-true branch 2 times, most recently from c959810 to e0c4e5f Compare September 20, 2024 09:24
@standeren standeren assigned framitdavid and unassigned standeren Sep 20, 2024
@standeren standeren force-pushed the fix/datepicker-timstamp-should-be-default-true branch from e0c4e5f to 331a3a5 Compare September 20, 2024 09:27
@framitdavid framitdavid assigned standeren and unassigned framitdavid Sep 20, 2024
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK, works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Status: 👷 In Progress
Development

Successfully merging this pull request may close these issues.

3 participants