Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-editor): poc a modal for adding components to form #13568

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nkylstad
Copy link
Member

DRAFT, only for comparing.

Description

POC for removing component column in favor of a button in-context of the form. The button opens a modal, where the service owner can select a component type to add, and edit the ID before adding to the form.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 49.41176% with 43 lines in your changes missing coverage. Please review.

Project coverage is 94.97%. Comparing base (016a826) to head (80d9a04).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ontainers/DesignView/AddItemModal/AddItemModal.tsx 35.71% 18 Missing ⚠️
...ners/DesignView/AddItemModal/ItemInfo/ItemInfo.tsx 43.75% 9 Missing ⚠️
...ignView/AddItemModal/ItemCategory/ItemCategory.tsx 50.00% 6 Missing ⚠️
...nd/packages/ux-editor/src/utils/formLayoutUtils.ts 25.00% 6 Missing ⚠️
...tainers/DesignView/AddItemModal/AddItemContent.tsx 70.00% 3 Missing ⚠️
...packages/ux-editor/src/containers/FormDesigner.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13568      +/-   ##
==========================================
- Coverage   95.16%   94.97%   -0.20%     
==========================================
  Files        1464     1470       +6     
  Lines       20163    20246      +83     
  Branches     2439     2448       +9     
==========================================
+ Hits        19189    19229      +40     
- Misses        868      910      +42     
- Partials      106      107       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant