Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: skipping default logic should only happen when authenticate fails #165

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Bugfix: skipping default logic should only happen when authenticate fails #165

merged 1 commit into from
Jul 31, 2024

Conversation

Andreass2
Copy link
Collaborator

@Andreass2 Andreass2 commented Jul 31, 2024 •
edited
Loading

Description

Only skip default login on authenticateFailure

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Andreass2 Andreass2 changed the title Only skip default login on authenticateFailure Bugfix: skipping default logic should only happen when authenticate fails Jul 31, 2024
@Andreass2 Andreass2 merged commit 3c03d0d into main Jul 31, 2024
4 checks passed
@Andreass2 Andreass2 deleted the bugfix/no-auth-gives-empty-200 branch July 31, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ceredron Ceredron Ceredron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andreass2 @Ceredron