Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for reported bugs #3268

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fixes for reported bugs #3268

merged 2 commits into from
Aug 9, 2023

Conversation

JamesSmartCell
Copy link
Member

  • Crash when getting top activity if app isn't running (WalletConnect V2)
  • Crash when attempting to start price alert service (note this is a band-aid, it doesn't have any negative side effects only that a service (price alerts) that caused the app to crash on that device now simply may no longer function).
  • Remove WalletConnect V1 connection monitoring (which was causing issues on some phones).
  • Add notification alert limiting for already active notifications.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (b316aa7) 7.40% compared to head (dad6eeb) 7.38%.
Report is 1 commits behind head on master.

❗ Current head dad6eeb differs from pull request most recent head af4c762. Consider uploading reports for the commit af4c762 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3268      +/-   ##
===========================================
- Coverage      7.40%   7.38%   -0.03%     
+ Complexity      907     905       -2     
===========================================
  Files           672     672              
  Lines         46257   46301      +44     
  Branches       4675    4684       +9     
===========================================
- Hits           3427    3420       -7     
- Misses        42534   42588      +54     
+ Partials        296     293       -3     
Files Changed Coverage Δ
app/src/main/java/com/alphawallet/app/App.java 0.00% <0.00%> (ø)
...lphawallet/app/service/AssetDefinitionService.java 4.98% <0.00%> (-0.01%) ⬇️
...lphawallet/app/service/WalletConnectV2Service.java 0.00% <0.00%> (ø)
...main/java/com/alphawallet/app/ui/HomeActivity.java 2.25% <0.00%> (-0.02%) ⬇️
...java/com/alphawallet/app/ui/MyAddressActivity.java 0.00% <0.00%> (ø)
.../src/main/java/com/alphawallet/app/util/Utils.java 10.90% <0.00%> (-0.42%) ⬇️
...a/com/alphawallet/app/viewmodel/HomeViewModel.java 25.85% <0.00%> (+0.33%) ⬆️
...allet/app/walletconnect/AWWalletConnectClient.java 4.94% <0.00%> (-0.22%) ⬇️
.../java/com/alphawallet/app/widget/CopyTextView.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Increase test setup delays to cope with slow execution
@JamesSmartCell JamesSmartCell merged commit 9ad52a9 into master Aug 9, 2023
6 checks passed
@JamesSmartCell JamesSmartCell deleted the stability-update branch August 9, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant