Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WalletConnect Sesssion List #3262

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

JamesSmartCell
Copy link
Member

Refactor WalletConnect display list so that it's clearer which sessions are active.

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (ae259ea) 7.40% compared to head (2051cbc) 7.39%.

❗ Current head 2051cbc differs from pull request most recent head dd3d897. Consider uploading reports for the commit dd3d897 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3262      +/-   ##
===========================================
- Coverage      7.40%   7.39%   -0.02%     
+ Complexity      907     904       -3     
===========================================
  Files           672     672              
  Lines         46238   46252      +14     
  Branches       4672    4673       +1     
===========================================
- Hits           3425    3419       -6     
- Misses        42518   42541      +23     
+ Partials        295     292       -3     
Impacted Files Coverage Δ
...entity/walletconnect/WalletConnectSessionItem.java 0.00% <0.00%> (ø)
...tity/walletconnect/WalletConnectV2SessionItem.java 0.00% <0.00%> (ø)
...lphawallet/app/interact/WalletConnectInteract.java 6.66% <0.00%> (-0.16%) ⬇️
...phawallet/app/ui/WalletConnectSessionActivity.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesSmartCell JamesSmartCell merged commit 8cbea5b into master Jul 10, 2023
6 checks passed
@JamesSmartCell JamesSmartCell deleted the refactor-walletconnect-session-list branch July 10, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant