Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quality_control.py #1059

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Update quality_control.py #1059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
015d9ce
Update quality_control.py
dbirman Sep 11, 2024
1a7dbf1
tests: fixing tests
dbirman Sep 11, 2024
eeac865
tests: one more missing test
dbirman Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/quality_control.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"name": "Extracellular electrophysiology",
"abbreviation": "ecephys"
},
"evaluation_stage": "Preprocessing",
"evaluation_stage": "Processing",
"evaluation_name": "Drift map",
"evaluation_description": "Qualitative check that drift map shows minimal movement",
"evaluator": "Fred Flintstone",
Expand Down
2 changes: 1 addition & 1 deletion examples/quality_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
evaluation_name="Drift map",
evaluation_description="Qualitative check that drift map shows minimal movement",
evaluation_modality=Modality.ECEPHYS,
evaluation_stage=Stage.PREPROCESSING,
evaluation_stage=Stage.PROCESSING,
evaluator="Fred Flintstone",
evaluation_date=t,
qc_metrics=[
Expand Down
2 changes: 1 addition & 1 deletion quality_control.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"name": "Extracellular electrophysiology",
"abbreviation": "ecephys"
},
"evaluation_stage": "Preprocessing",
"evaluation_stage": "Processing",
"evaluation_name": "Drift map",
"evaluation_desc": "Qualitative check that drift map shows minimal movement",
"evaluator": "Fred Flintstone",
Expand Down
2 changes: 1 addition & 1 deletion src/aind_data_schema/core/quality_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Stage(str, Enum):
"""

RAW = "Raw data"
PREPROCESSING = "Preprocessing"
PROCESSING = "Processing"
ANALYSIS = "Analysis"


Expand Down
2 changes: 1 addition & 1 deletion tests/test_quality_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def test_constructors(self):
evaluator="Bob",
evaluation_date=date.fromisoformat("2020-10-10"),
evaluation_modality=Modality.ECEPHYS,
evaluation_stage=Stage.PREPROCESSING,
evaluation_stage=Stage.PROCESSING,
qc_metrics=[
QCMetric(
name="Multiple values example",
Expand Down
Loading