feat: add pending option to QC status #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtyoung84 any insight about why the tests might be suddenly failing with this single-line addition? I can't get these failures to reproduce on my local python install. |
|
Which version of pydantic are you running locally? We don't have an upper bound, so github actions is using 2.9.0, which is pretty new. We can add an upper bound to pyproject.toml if that's the issue. |
|
Yep that's it, runs fine on 2.8. Looks like there might be breaking changes in 2.9. I can make a separate PR to restrict to <=2.8 and open an issue for the upgrade? |
Maybe set it to <2.9? |
saskiad
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.