Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: making all use of Field(default=None) consistent for Optional … #1041

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

dbirman
Copy link
Member

@dbirman dbirman commented Aug 29, 2024

…fields

@dbirman dbirman linked an issue Aug 29, 2024 that may be closed by this pull request
@dbirman dbirman requested a review from saskiad August 29, 2024 18:15
@dbirman
Copy link
Member Author

dbirman commented Aug 29, 2024

This way I don't have to be confused when I look at older files for examples!

Copy link
Collaborator

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@saskiad
Copy link
Collaborator

saskiad commented Aug 30, 2024

Thanks for doing this - I thought it had been done earlier, but obviously it missed some places.

@saskiad saskiad added this pull request to the merge queue Aug 30, 2024
Merged via the queue into dev with commit 1cac657 Aug 30, 2024
5 checks passed
@saskiad saskiad deleted the 1040-fielddefault=none-consistency-for-optional-fields branch August 30, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field(default=None, ) consistency for optional fields
2 participants