Skip to content

Commit

Permalink
Update quality_control.py (#1059)
Browse files Browse the repository at this point in the history
* Update quality_control.py

* tests: fixing tests

* tests: one more missing test
  • Loading branch information
dbirman authored Sep 12, 2024
1 parent 4e6ee98 commit f10b06b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion examples/quality_control.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"name": "Extracellular electrophysiology",
"abbreviation": "ecephys"
},
"evaluation_stage": "Preprocessing",
"evaluation_stage": "Processing",
"evaluation_name": "Drift map",
"evaluation_description": "Qualitative check that drift map shows minimal movement",
"evaluator": "Fred Flintstone",
Expand Down
2 changes: 1 addition & 1 deletion examples/quality_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
evaluation_name="Drift map",
evaluation_description="Qualitative check that drift map shows minimal movement",
evaluation_modality=Modality.ECEPHYS,
evaluation_stage=Stage.PREPROCESSING,
evaluation_stage=Stage.PROCESSING,
evaluator="Fred Flintstone",
evaluation_date=t,
qc_metrics=[
Expand Down
2 changes: 1 addition & 1 deletion quality_control.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"name": "Extracellular electrophysiology",
"abbreviation": "ecephys"
},
"evaluation_stage": "Preprocessing",
"evaluation_stage": "Processing",
"evaluation_name": "Drift map",
"evaluation_desc": "Qualitative check that drift map shows minimal movement",
"evaluator": "Fred Flintstone",
Expand Down
2 changes: 1 addition & 1 deletion src/aind_data_schema/core/quality_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Stage(str, Enum):
"""

RAW = "Raw data"
PREPROCESSING = "Preprocessing"
PROCESSING = "Processing"
ANALYSIS = "Analysis"


Expand Down
2 changes: 1 addition & 1 deletion tests/test_quality_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def test_constructors(self):
evaluator="Bob",
evaluation_date=date.fromisoformat("2020-10-10"),
evaluation_modality=Modality.ECEPHYS,
evaluation_stage=Stage.PREPROCESSING,
evaluation_stage=Stage.PROCESSING,
qc_metrics=[
QCMetric(
name="Multiple values example",
Expand Down

0 comments on commit f10b06b

Please sign in to comment.