add a special type for IDs #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make it less possible to change some IDs and cause strange layout behaviours Sometimes, when there were nested layouts and some of them were dynamically generated depending on other widgets, it caused some strange UI behaviours
If something has type ID, it means that it will not be proceeded by GenAutoID and will be passed as-is to cimgui
|
@gucio321 Let me take a look, get back to you later, thanks for your effort! |
|
@gucio321 LGTM go ahead pls. |
|
ok, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AllenDang I did something like this, is it ok?