Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python-dev #89

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Remove python-dev #89

merged 1 commit into from
Jun 20, 2023

Conversation

ed1d1a8d
Copy link
Collaborator

@ed1d1a8d ed1d1a8d commented Jun 20, 2023

python-dev no longer exists in the latest versions of debian, see e.g. the build failure here https://app.circleci.com/pipelines/github/AlignmentResearch/KataGoVisualizer/653/workflows/c09a6929-e51a-4458-8b5f-eeee32dba983/jobs/1316

I've removed python-dev (which we never needed cause the container comes with python 3.10), and also adjusted the pip install process to work better. Namely, I merged the tensorflow install line with the requirements line. Installing tensorflow separately would also upgrade protobuf to a version that is incompatible with streamlit. The --use-pep517 is to address pypa/pip#8559.

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for goattack canceled.

Name Link
🔨 Latest commit 0c67719
🔍 Latest deploy log https://app.netlify.com/sites/goattack/deploys/6491eb9017621e0007522bee

@ed1d1a8d ed1d1a8d marked this pull request as ready for review June 20, 2023 19:05
@ed1d1a8d ed1d1a8d merged commit 4faadea into main Jun 20, 2023
@ed1d1a8d ed1d1a8d deleted the tony/remove-python-dev branch June 20, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant