Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT-17527 Add support for annotation layer #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yregaieg
Copy link

In order to have clickable links in PDFJS viewer in Alfresco Share, the annotation layer needs to be rendered. In this PR, I added the support for this feature and added an activation flag (defaulting to true) as discussed with @esplinr.
Alfresco can switch that back to false by default and have a config entry (in share-config-custom.xml for instance) defining that setting.
IMHO it should be active by default (as it was with the swf previews back in 4.x) and customers can opt out of the feature by a simple extension setting the activation flag to false.

@davidcognite
Copy link
Contributor

Thanks for the PR! As referenced in the title, we've already got an MNT ticket for this: https://issues.alfresco.com/jira/browse/MNT-17527 - so will continue the discussion there about getting this fix reviewed and merged.

@@ -1902,7 +1913,7 @@
this.textLayerDiv = null;
this.config = config || {};
this.textContent = null;
this.textLayerDiv = null;
this.annotationLayerDiv = null;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you removed the parameter variable textLayerDiv here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget it. You created a copy of the original one, and then changed it to annotationLayerDiv... sorry

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@douglascrp well... I reused an existing (duplicate property), instead of adding a new one..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants