-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-7630] Add Keycloak Tutorial to ACS 7.3+ #1432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all files except kerberos.md
and ldap.md
. I believe there are quite a few things to change so I'll stop here until they're addressed and my review is re-requested.
Thanks for taking care of this 🙏
NOTE: there are a lot of suggestions, so remember to hit the "Load More" button to see all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more considerations and added @balsarori as a reviewer to answer to some of the questions & double-check that the APS properties are up-to-date and still make sense after the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.