Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2364 Fixup support of multiple helm keys in search chart #14

Merged
merged 2 commits into from
Nov 8, 2023
Merged

OPSEXP-2364 Fixup support of multiple helm keys in search chart #14

merged 2 commits into from
Nov 8, 2023

Conversation

gionn
Copy link
Member

@gionn gionn commented Nov 7, 2023 •
edited
Loading

@gionn gionn self-assigned this Nov 7, 2023
@gionn gionn force-pushed the OPSEXP-2364-fixup-search-multiple-keys branch from 0171583 to c4262ab Compare November 7, 2023 15:18
@gionn gionn requested a review from alxgomz November 7, 2023 15:26
@gionn gionn marked this pull request as ready for review November 7, 2023 15:26
alxgomz
alxgomz approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why we need $target_search_helm but ok.

@gionn
Copy link
Member Author

gionn commented Nov 8, 2023

not sure why we need $target_search_helm but ok.

using range replace the root scope, I tried switching to $. but it was still empty, I hate go tpl

@gionn gionn merged commit 61a7427 into master Nov 8, 2023
1 check passed
@gionn gionn deleted the OPSEXP-2364-fixup-search-multiple-keys branch November 8, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

Assignees

@gionn gionn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gionn @alxgomz