Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: ATS-812 - PoC FFmpeg skeleton - please keep (for experiments) - do not merge #364

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

WIP: ATS-812 - PoC FFmpeg skeleton - please keep (for experiments) - do not merge #364

wants to merge 30 commits into from

Conversation

montgolfiere
Copy link
Contributor

  • DO NOT MERGE

montgolfiere and others added 6 commits July 27, 2020 19:08
@montgolfiere
ATS-812: PoC for FFmpeg T-Engine (WIP) - initial folder skeleton
186e187 
- note: PoC only - limited functionality & no tests yet
- see also ATS-793 epic
@montgolfiere
ATS-812: PoC for FFmpeg T-Engine (WIP) - initial folder skeleton
7d8c8e6 
- before I forget, tweak docker image name (=> alfresco-transform-...)
@montgolfiere
ATS-812: PoC for FFmpeg T-Engine (WIP) - initial folder skeleton
c88cb02 
- before I forget, tweak docker image name and also add "poc" (eg. alfresco-transform-ffmpeg-poc)
@TheOutsSeeker @montgolfiere
ATS-850_Disable_WhiteSource_Veracode_scans (#325)
8107134 
* Disable WhiteSource & Veracode scans
* Disable Veracode scans

(cherry picked from commit c3acdfa)
@montgolfiere
Merge branch 'master' into ATS-812_PoC_FFmpeg_skeleton
f4126b4 
* master: (77 commits)
  [maven-release-plugin][skip ci] prepare for next development iteration
  [maven-release-plugin][skip ci] prepare release 2.3.10
  ATS-876: Release ATS 1.3.2 [trigger release] (#360)
  ACS-1185: Bump ActiveMQ client in T-Core (#359)
  [maven-release-plugin][skip ci] prepare for next development iteration
  [maven-release-plugin][skip ci] prepare release 2.3.9
  ATS-876: Release ATS 1.3.2 [trigger release] (#358)
  Bump alfresco/alfresco-base-java (#353)
  Bump alfresco/alfresco-base-java (#352)
  Bump alfresco/alfresco-base-java (#354)
  Bump alfresco/alfresco-base-java (#355)
  Bump alfresco/alfresco-base-java (#356)
  Bump alfresco/alfresco-base-java (#357)
  Bump alfresco/alfresco-base-java (#345)
  Bump alfresco/alfresco-base-java (#346)
  Bump alfresco/alfresco-base-java (#347)
  Bump alfresco/alfresco-base-java (#348)
  Bump alfresco/alfresco-base-java (#349)
  Bump alfresco/alfresco-base-java (#350)
  Bump spring-boot-starter-parent from 2.4.2 to 2.4.3 (#344)
  ...
@montgolfiere
ATS-812: PoC FFmpeg skeleton - experimental
81cbf0e 
- merge in master (~ 2.3.11-SNAPSHOT)
@pr-triage pr-triage bot added the PR: draft label Mar 29, 2021
@montgolfiere
ATS-812: PoC FFmpeg skeleton - experimental
8c3ac3f 
- add *skeleton* of unit tests based on other T-Engines (incomplete)
- TODO add more tests, re: specific FFmpeg transform options (+ more src/tgt media types)
@montgolfiere
ATS-812: PoC FFmpeg skeleton - experimental
05169a8 
- run *skeleton* of unit tests (incomplete)
- TODO add more tests, re: specific FFmpeg transform options (+ more src/tgt media types)
@montgolfiere
ATS-812: PoC FFmpeg skeleton - experimental
9665a6d 
- temp comment-out other non-FFmpeg tests so that they don't run on Travis (DO NOT MERGE) ;-)
@montgolfiere
ATS-812: PoC FFmpeg skeleton - experimental
926ac11 
- trivial: fix typo in name (pom.xml)
@montgolfiere
ATS-812: PoC FFmpeg skeleton - unit test fixes
9c4a239 
- fix the -ve unit test files (back to same as other T-Engines)
- for now, remove the empty FFmpeg t-options

- TODO add some example config options (+ unit tests)
@montgolfiere
ATS-812: PoC FFmpeg skeleton - experiments
8dacb86 
- fix typo in name (pom.xml)
- temporarily downgrade to CentOS 7 base docker image (=> ~ FFmpeg 3.4.8-1)

- TODO upgrade to CentOS 8 base docker image (=> ~ FFmpeg 4.2.4)
@montgolfiere
ATS-812: PoC FFmpeg skeleton - experiments
d0d1fd8 
- quick PoC hack to update Dockerfile to FFmpeg 4.2.4 on CentOS 8 (from 3.4.8-1 on CentOS 7) base docker image

- TODO raise story/task to do this properly (as part of epic) !
@montgolfiere
ATS-812: PoC FFmpeg skeleton - experiments
b8c1463 
- add PoC option to convert from mp4 to either image/png or image/png
- single frame based on timeOffset param (example format "00:00:00.5")
- transform option names & support mimetypes subject to change
- requires detailed design + (unit) regression tests

- see also MM-156
@montgolfiere montgolfiere changed the title Draft (WIP): ATS-812 - PoC FFmpeg skeleton - for learning experiments Draft (WIP): ATS-812 - PoC FFmpeg skeleton - for experiments & learning Dec 21, 2021
@montgolfiere
ATS-812: PoC FFmpeg - minor: add extra (internal) check for src/tgt m…
aa16bb1 
…edia types
@montgolfiere
Merge commit '0c939761299358bec8084ab7675d0a4798d09b16' into ATS-812_…
2c68e29 
…PoC_FFmpeg_skeleton

* commit '0c939761299358bec8084ab7675d0a4798d09b16': (97 commits)
  [maven-release-plugin][skip ci] prepare release 2.5.4
  ACS-1998 Enhance the transform config (#484)
  Bump guava from 30.1.1-jre to 31.0.1-jre (#473)
  Bump jsoup from 1.14.2 to 1.14.3 (#475)
  Bump dependency.jackson.version from 2.12.5 to 2.13.0 (#476)
  Bump dependency.cxf.version from 3.4.4 to 3.4.5 (#477)
  Bump spring-boot-starter-parent from 2.5.4 to 2.5.6 (#479)
  ATS-970: Fix build after Travis secrets rotation (#469)
  Bump maven-javadoc-plugin from 3.3.0 to 3.3.1 (#466)
  Bump dependency.jackson.version from 2.12.4 to 2.12.5 (#464)
  [maven-release-plugin][skip ci] prepare for next development iteration
  [maven-release-plugin][skip ci] prepare release 2.5.3
  ATS-956: Release Alfresco Transform Core 2.5.3 [trigger release] (#463)
  Bump docker-maven-plugin from 0.36.1 to 0.37.0 (#450)
  Bump jsoup from 1.14.1 to 1.14.2 (#451)
  Bump activemq-client from 5.16.2 to 5.16.3 (#452)
  Bump spring-boot-starter-parent from 2.5.3 to 2.5.4 (#454)
  Bump alfresco/alfresco-base-java (#458)
  Bump alfresco/alfresco-base-java (#456)
  Bump alfresco/alfresco-base-java (#457)
  ...

# Conflicts:
#	.travis.yml
@montgolfiere
ATS-812: PoC FFmpeg
6630498 
- temp comment out other T-Engine jobs (do not merge)
@montgolfiere
ATS-812: PoC FFmpeg (experimental) - bump pom.xml to 2.5.5-A1-SNAPSHOT
dbafd81
@montgolfiere
ATS-812: PoC FFmpeg (experimental) - bump pom.xml to 2.5.5-A1-SNAPSHOT
48c11c4
@montgolfiere
Merge commit '2fd8361a783f117592b55bbca4fc7273adf1db49' into ATS-812_…
c6d88fe 
…PoC_FFmpeg_skeleton

* commit '2fd8361a783f117592b55bbca4fc7273adf1db49': (25 commits)
  [maven-release-plugin][skip ci] prepare for next development iteration
  [maven-release-plugin][skip ci] prepare release 2.5.5-A1
  [trigger release] 2.5.5-A1 (#511)
  [trigger release] 2.5.5-A1
  Bump dependency.jackson.version from 2.13.0 to 2.13.1
  Bump dependency.cxf.version from 3.4.5 to 3.5.0
  Revert "Bump dependency.tika.version from 2.1.0 to 2.2.1"
  Bump dependency.tika.version from 2.1.0 to 2.2.1
  ACS-2002 Enhance T-Router debug (#507)
  Bump license-maven-plugin from 2.0.0 to 2.0.1.alfresco-1 (#481)
  Bump bcmail-jdk15on from 1.69 to 1.70 (#492)
  Bump bcprov-jdk15on from 1.69 to 1.70 (#491)
  Bump spring-boot-starter-parent from 2.6.0 to 2.6.2 (#504)
  ACS-2352: Added Veracode agent-based scanning integration.
  Bump joda-time from 2.2 to 2.10.13
  ATS-969 Tika upgrade 1.x -> 2.x (#493)
  ATS-968 Migrate to CentOS 7 base images (#490)
  ACS-1983 CentOS 7 base image for the ImageMagic transformer (#489)
  Update travis linux dist to Focal (#478)
  Bump spring-boot-starter-parent from 2.5.6 to 2.6.0
  ...

# Conflicts:
#	alfresco-transform-core-aio/alfresco-transform-core-aio-boot/pom.xml
#	alfresco-transform-core-aio/alfresco-transform-core-aio/pom.xml
#	alfresco-transform-imagemagick/alfresco-transform-imagemagick-boot/pom.xml
#	alfresco-transform-imagemagick/alfresco-transform-imagemagick/pom.xml
#	alfresco-transform-libreoffice/alfresco-transform-libreoffice-boot/pom.xml
#	alfresco-transform-libreoffice/alfresco-transform-libreoffice/pom.xml
#	alfresco-transform-misc/alfresco-transform-misc-boot/pom.xml
#	alfresco-transform-misc/alfresco-transform-misc/pom.xml
#	alfresco-transform-pdf-renderer/alfresco-transform-pdf-renderer-boot/pom.xml
#	alfresco-transform-pdf-renderer/alfresco-transform-pdf-renderer/pom.xml
#	alfresco-transform-tika/alfresco-transform-tika-boot/pom.xml
#	alfresco-transform-tika/alfresco-transform-tika/pom.xml
#	alfresco-transformer-base/pom.xml
#	pom.xml
@montgolfiere
ATS-812: PoC FFmpeg (experimental) - comment out T-Engine jobs except…
d1f38d3 
… FFmpeg (do not merge)
@montgolfiere
ATS-812: PoC FFmpeg (experimental)
dba3400 
- remove extra isTransformable check (& related isSupported src/tgt) for now
- add mov to mp4 to supported src/tgt config
- update lic headers to 2022
@montgolfiere
ATS-812: PoC FFmpeg (experimental) - "fix" testPojoTransform
9f18bd5 
- same as other mock tests, eg. see ImageMagickControllerTest
- although it seems some fields should be optional for pojo serialization (mock test)
@montgolfiere
ATS-812: PoC FFmpeg (experimental) - add duration (in addition to tim…
ec5a813 
…eOffset) to enable video/audio trim

- only set default frames num (1) if target is a supported image format (note: currently configured for jpg and png)
@montgolfiere
ATS-812: PoC FFmpeg (experimental) - add frame width & height
a0ec144 
- eg. to demo transcoding of video resolution (or even resize of frame if output to an image)
@montgolfiere montgolfiere changed the title Draft (WIP): ATS-812 - PoC FFmpeg skeleton - for experiments & learning WIP: ATS-812 - PoC FFmpeg skeleton - please keep (for experiments & learning) - do not merge Feb 2, 2022
@montgolfiere montgolfiere changed the title WIP: ATS-812 - PoC FFmpeg skeleton - please keep (for experiments & learning) - do not merge WIP: ATS-812 - PoC FFmpeg skeleton - please keep (for experiments) - do not merge Feb 2, 2022
@montgolfiere
ATS-812: PoC for FFmpeg T-Engine (WIP) - add conversion to animated gif
34bd371 
- circular inspiration ( https://hub.alfresco.com/t5/alfresco-content-services-blog/hackathon-project-animated-gif-transformer/ba-p/311115 )
@montgolfiere
ATS-812: PoC for FFmpeg T-Engine (WIP) - fix build
14e7761 
- went from green to red (when building docker image - apparently change in FFmpeg install)
- took the opportunity to switch to supported Java Base Image (ie. CentOS 7 LTS instead of CentOS 8)
- hence, for now (for PoC) floating FFmpeg v3.x (rather than v4.x)
@montgolfiere
Merge branch 'master' into ATS-812_PoC_FFmpeg_skeleton
462468a 
* master: (52 commits)
  [maven-release-plugin][skip ci] prepare for next development iteration
  [maven-release-plugin][skip ci] prepare release 2.5.7-A4
  ACS-2587 Fix test failure
  ACS-2587 Include directAccessUrl in T-Config if supported (#539)
  ATS-864: fix dependabot
  ATS-864: Switch from fabric8 to docker mvn plugin (#436)
  ACS-2072 Enforce third party license compliance.
  [maven-release-plugin][skip ci] prepare for next development iteration
  [maven-release-plugin][skip ci] prepare release 2.5.7-A3
  [trigger release] 2.5.7-A3
  Bump activemq-client from 5.16.3 to 5.16.4 (#534)
  Bump maven-javadoc-plugin from 3.3.1 to 3.3.2 (#533)
  ATS-981 Avoid CVE-2022-23181 with spring-boot-starter-web 2.6.3 (#537)
  [maven-release-plugin][skip ci] prepare for next development iteration
  [maven-release-plugin][skip ci] prepare release 2.5.7-A2
  [trigger release] 2.5.7-A2
  ACS-2497 Rework httpTransformRequestUsingDirectAccessUrlTest so it can be used in AI and Aspose (#535)
  Bump docker-maven-plugin from 0.38.1 to 0.39.0 (#528)
  [maven-release-plugin][skip ci] prepare for next development iteration
  [maven-release-plugin][skip ci] prepare release 2.5.7-A1
  ...

# Conflicts:
#	.travis.yml
#	alfresco-transformer-base/src/main/java/org/alfresco/transformer/util/RequestParamMap.java

Also bumped pom.xml version (for two ffmpeg folders) from 2.5.5-A2-SNAPSHOT to match others (2.5.7-A5-SNAPSHOT)
@montgolfiere
ATS-812: FFmpeg PoC (skeleton)
8005581 
- update FFmpeg Travis job (to match others)
@montgolfiere
ATS-812: FFmpeg PoC (skeleton)
7330485 
- fix tests: add new coreVersion (transform.core.verson) to match other T-Engines
@ArtyomPanfutov
Copy link

I'm looking for this kind of transformation using ffpmeg.
Are there plans to release it someday?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge 🙅🏻‍♂️ PR: draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montgolfiere @ArtyomPanfutov @TheOutsSeeker