[ACS-8247] Fixed empty context menu for DataTable row #9999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-web-ua
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
MichalKinas
approved these changes
Jul 26, 2024
swapnil-verma-gl
approved these changes
Jul 29, 2024
g-jaskowski
approved these changes
Jul 29, 2024
dominikiwanekhyland
approved these changes
Jul 29, 2024
DenysVuika
reviewed
Aug 1, 2024
| @@ -699,6 +699,13 @@ export class DataTableComponent implements OnInit, AfterContentInit, OnChanges, | |||
| } | |||
| } | |||
|
|
|||
| onCheckboxLabelClick(row: DataRow, event: MouseEvent) { | |||
| const target = event.target as HTMLElement; | |||
| if (!(target.tagName === 'MAT-CHECKBOX' || target.closest('mat-checkbox'))) { | |||
There was a problem hiding this comment.
can we have some data-attribute instead? otherwise we hardcode the material checkbox there, and things might break later if we change the component
There was a problem hiding this comment.
good point, replaced with attribute, thanks
nikita-web-ua
force-pushed
the
dev-mmaliarchuk/ACS-8247-empty-context-menu
branch
from
9418947
to
a0b0dd0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8247
What is the new behaviour?
The area around the checkbox is now treated the same as the rest of the data table row.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: