Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-21797] Datetime widget Min/Max values are checked on a field that is not required #9524

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

BSekula
Copy link
Contributor

@BSekula BSekula commented Apr 8, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@BSekula BSekula changed the title [AAE-21797] Datetime widget Min/Max values are checked on a field tha… [AAE-21797] Datetime widget Min/Max values are checked on a field that is not required Apr 8, 2024
@BSekula BSekula requested a review from wiktord2000 April 8, 2024 09:35
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@BSekula BSekula merged commit 951b8db into develop Apr 8, 2024
32 of 33 checks passed
@BSekula BSekula deleted the dev-bsekula-AAE-21797-fix-empty-date-time branch April 8, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants