-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-6150] Add category selector dialog #9423
[ACS-6150] Add category selector dialog #9423
Conversation
lib/content-services/src/lib/category/categories-management/categories-management.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/dialogs/category-selector.dialog.html
Outdated
Show resolved
Hide resolved
070cb47
to
651bd34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall PR looks good to me, I only wonder should we change the background with the list of categories to plain white for the dialog?
It is white:) In the example screenshot there is single selection mode and a category already selected, so the rest of the list is disabled. |
Ah okay, thanks for the explanation, all good then :) |
Yeah @MichalKinas I had the same doubts and I added the same comment here: #9423 (comment) I can see that even Tags have actually that gray background: but in initial design when we were implementing that there was not gray background if I remember properly, see attached designs and Akash's video after verification in comments in that task: |
651bd34
to
3a18fbf
Compare
bee3c92
to
0c0f04c
Compare
0c0f04c
to
c34f77c
Compare
Quality Gate passedIssues Measures |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Folder rules 'Link category' action has a text input that requires the user to enter the category ID manually, which is inconvenient. With this dialog you could select it from a list.
What is the new behaviour?
Category selector dialog was added to select one or multiple categories.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ACS-6150