[ACS-6565] ADW - Document List View Header - UX Bugs (Additional fixes) #9404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekpluta
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
jacekpluta
force-pushed
the
ACS-6565-Document-List-View-Header-UX-Bugs-icon-fix
branch
from
c784980
to
3fa94fb
Compare
jacekpluta
force-pushed
the
ACS-6565-Document-List-View-Header-UX-Bugs-icon-fix
branch
from
3fa94fb
to
672f70a
Compare
lib/core/src/lib/datatable/components/datatable/datatable.component.scss
Outdated
Show resolved
Hide resolved
lib/core/src/lib/datatable/components/datatable/datatable.component.spec.ts
Outdated
Show resolved
Hide resolved
jacekpluta
force-pushed
the
ACS-6565-Document-List-View-Header-UX-Bugs-icon-fix
branch
from
3fa94fb
to
ad5537a
Compare
nikita-web-ua
approved these changes
Mar 4, 2024
AleksanderSklorz
approved these changes
Mar 5, 2024
jacekpluta
force-pushed
the
ACS-6565-Document-List-View-Header-UX-Bugs-icon-fix
branch
from
ad5537a
to
d716b8e
Compare
MichalKinas
approved these changes
Mar 8, 2024
jacekpluta
force-pushed
the
ACS-6565-Document-List-View-Header-UX-Bugs-icon-fix
branch
from
4ef15b2
to
c0a4370
Compare
|
jacekpluta
deleted the
ACS-6565-Document-List-View-Header-UX-Bugs-icon-fix
branch
AleksanderSklorz
pushed a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-6565
Points: 1, 9, 10, 12
What is the new behaviour?
Point 1. After talking to Shane, we have decided to removed drag boundary on X axis which resolves this issue.
Point 9. After talking to Shane, we have decided to remove drag handle on the last column and the last column always takes the remaining space.
Point 10. Added ellipsis to the columns in ACA.
Point 12. Changed tooltip position to the left.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: