[ACS-6643] Incorrect layout for Search widgets of the Text type #9310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamaragruszka
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
tamaragruszka
changed the title
MichalKinas
requested changes
Feb 7, 2024
| @@ -1,6 +1,5 @@ | |||
| .adf-search-text { | |||
| .mat-form-field { | |||
| width: 100%; | |||
| max-width: 168px; | |||
There was a problem hiding this comment.
I wonder a bit about the bug that introduced this fix before your PR, maybe we should use hidden instead of ngIf for the clear button to ensure that layout won't "jump" in case this component is used in similar scenario as in that bug
There was a problem hiding this comment.
I checked in application, it's not jumping anymore
There was a problem hiding this comment.
But the bug was introduced in the HX app, so you would need to check it there or apply suggested changes
MichalKinas
approved these changes
Feb 9, 2024
tamaragruszka
changed the title
…widgets-of-the-text-type
|
tamaragruszka
deleted the
ACS-6643-adf-incorrect-layout-for-search-widgets-of-the-text-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Constant width for textfield
ACS-6643
What is the new behaviour?
Textfield adjust to parent width
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: