[ACS-6620] Proper viewer extension template projection to viewer renderer #9273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalKinas
requested review from
jacekpluta,
nikita-web-ua,
swapnil-verma-gl,
AleksanderSklorz,
dominikiwanekhyland and
tamaragruszka
MichalKinas
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
DenysVuika
approved these changes
Jan 24, 2024
|
MichalKinas
deleted the
bugfix/mkinas-ACS-6620-adf-viewer-stopped-supporting-custom-extensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Extensions provided via HTML projection stopped working after viewer refactoring.
What is the new behaviour?
The solution has been adapted to the new viewer structure after the refactoring, right now it's possible to provide a template with one or multiple
ViewerExtensionDirectiveon both viewer levels. Provided extensions will be correctly displayed based on file extension and mime type and will override default ones if specified insupportedExtensionsinput. See https://alfresco.atlassian.net/browse/ACS-6620Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: