Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-19600 Inconsistency between UI model name and name stored in json… #9252

Conversation

elena-grosu-h
Copy link
Contributor

@elena-grosu-h elena-grosu-h commented Jan 18, 2024

… file

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • [x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-19600

What is the new behaviour?
Only one change was made to the file /alfresco-ng2-components/e2e/resources/activiti7/uat-be-default-app.zip/ui/digital-workspace-ui.json.
Updates:
"name": "digital-workspace-ui-model"(Actual result) => "name": "digital-workspace-ui"(PR changes)


Ensure coherence between the file name and the name within the file.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • [x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2024

CLA assistant check
All committers have signed the CLA.

@elena-grosu-h elena-grosu-h force-pushed the AAE-19600-inconsistency-between-ui-model-name-and-name-stored-in-json-file branch from a78f665 to 83caf99 Compare January 18, 2024 13:37
@elena-grosu-h elena-grosu-h force-pushed the AAE-19600-inconsistency-between-ui-model-name-and-name-stored-in-json-file branch 3 times, most recently from c0c1e7d to 11540b9 Compare January 25, 2024 13:04
@elena-grosu-h elena-grosu-h force-pushed the AAE-19600-inconsistency-between-ui-model-name-and-name-stored-in-json-file branch 2 times, most recently from 11540b9 to 96e1096 Compare January 25, 2024 14:41
@elena-grosu-h elena-grosu-h force-pushed the AAE-19600-inconsistency-between-ui-model-name-and-name-stored-in-json-file branch from 96e1096 to 26f345e Compare January 25, 2024 14:57
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@VitoAlbano VitoAlbano merged commit 69f24a1 into develop Jan 25, 2024
33 checks passed
@VitoAlbano VitoAlbano deleted the AAE-19600-inconsistency-between-ui-model-name-and-name-stored-in-json-file branch January 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants