Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-19365] Fix for changelog generation #9226

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

popovicsandras
Copy link
Contributor

@popovicsandras popovicsandras commented Jan 11, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour?
https://alfresco.atlassian.net/browse/AAE-19365
Changelog generation fails in special cases, when commit message contains special characters like "\n".

What is the new behaviour?
Changelog generation doesn't throw error in such extreme cases and informs the developer to apply patch manually.

new-behaviour

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@eromano eromano merged commit daa8183 into develop Jan 12, 2024
35 checks passed
@eromano eromano deleted the AAE-19365-fox-for-changelog-generation branch January 12, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants