[AAE-16965] Improve data table date column #9038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomgny
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
lib/core/src/lib/datatable/components/date-cell/date-cell.component.ts
Outdated
Show resolved
Hide resolved
wiktord2000
reviewed
Oct 30, 2023
lib/core/src/lib/datatable/components/date-cell/date-cell.component.ts
Outdated
Show resolved
Hide resolved
wiktord2000
reviewed
Oct 30, 2023
| locale: undefined | ||
| }; | ||
|
|
||
| constructor(private readonly appConfig: AppConfigService) { |
There was a problem hiding this comment.
Can we use inject() feature over here?
mauriziovitale
approved these changes
Oct 30, 2023
wiktord2000
reviewed
Oct 30, 2023
Comment on lines
56
to
67
| private setDefaultConfig(): void { | ||
| if (this.dateConfig) { | ||
| this.config.format = this.dateConfig?.format ?? (this.column?.format || this.getAppConfigPropertyValue('dateValues.defaultDateFormat', this.defaultDateConfig.format)); | ||
| this.config.tooltipFormat = this.dateConfig?.tooltipFormat || this.getAppConfigPropertyValue('dateValues.defaultTooltipDateFormat', this.defaultDateConfig.tooltipFormat); | ||
| this.config.locale = this.dateConfig?.locale || this.getAppConfigPropertyValue('dateValues.defaultLocale', this.defaultDateConfig.locale); | ||
| } else { | ||
| this.config = this.defaultDateConfig; | ||
| } | ||
| } | ||
|
|
||
| private getAppConfigPropertyValue(key: string, defaultValue: string): string { | ||
| return this.appConfig.get(key, defaultValue); | ||
| } |
There was a problem hiding this comment.
Suggested change
| private setDefaultConfig(): void { | |
| if (this.dateConfig) { | |
| this.config.format = this.dateConfig?.format ?? (this.column?.format || this.getAppConfigPropertyValue('dateValues.defaultDateFormat', this.defaultDateConfig.format)); | |
| this.config.tooltipFormat = this.dateConfig?.tooltipFormat || this.getAppConfigPropertyValue('dateValues.defaultTooltipDateFormat', this.defaultDateConfig.tooltipFormat); | |
| this.config.locale = this.dateConfig?.locale || this.getAppConfigPropertyValue('dateValues.defaultLocale', this.defaultDateConfig.locale); | |
| } else { | |
| this.config = this.defaultDateConfig; | |
| } | |
| } | |
| private getAppConfigPropertyValue(key: string, defaultValue: string): string { | |
| return this.appConfig.get(key, defaultValue); | |
| } | |
| private setDefaultConfig(): void { | |
| if(!this.dateConfig){ | |
| this.config = this.defaultDateConfig; | |
| return; | |
| } | |
| this.config.format = this.dateConfig?.format ?? (this.column?.format || this.getAppConfigPropertyValue('dateValues.defaultDateFormat', this.defaultDateConfig.format)); | |
| this.config.tooltipFormat = this.dateConfig?.tooltipFormat || this.getAppConfigPropertyValue('dateValues.defaultTooltipDateFormat', this.defaultDateConfig.tooltipFormat); | |
| this.config.locale = this.dateConfig?.locale || this.getAppConfigPropertyValue('dateValues.defaultLocale', this.defaultDateConfig.locale); | |
| } | |
| private getAppConfigPropertyValue(key: string, defaultValue: string): string { | |
| return this.appConfig.get(key, defaultValue); | |
| } |
There was a problem hiding this comment.
In this case is nice to avoid the else{} block and just handle 'smaller' stuff at the beginning and get use of return; I think
tomgny
force-pushed
the
AAE-16965-handle-date-column
branch
from
f25ee9a
to
44f6220
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-16965
What is the new behaviour?
New
dateConfigparams to better configure displayed date values, with backward compatibility (handle column.format)Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
It might have impact for components/modules that imports Pipes (adfLocalizedDate, adfTimeAgo) that are changed to standalone
Other information: