[ACS-5572] Remove unused Social components #8758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-jaskowski
requested review from
nikita-web-ua,
swapnil-verma-gl,
MichalKinas and
AleksanderSklorz
g-jaskowski
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
|
@DenysVuika same thing of the other rigth we should not remove only deprecate |
|
@eromano Those two components have a second PR with only marking as deprecated, same as the previous WebScript component. The removal changes were pushed on this branch only because they had already been done locally. Sorry for the confusion |
|
@g-jaskowski not sure I got :) does it mean you can close this PR? |
g-jaskowski
force-pushed
the
ACS-5572-ADF-Deprecate-Social-components
branch
4 times, most recently
from
3e10c04
to
5a1a0d8
Compare
g-jaskowski
force-pushed
the
ACS-5572-ADF-Deprecate-Social-components
branch
from
5a1a0d8
to
d2ff6d9
Compare
|
dominikiwanekhyland
approved these changes
Apr 12, 2024
DenysVuika
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Jira: ACS-5572
What is the new behaviour?
Removed unused Like and Rating components and sidenav Social label from demoshell.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Like and Rating components are not used outside ADF demoshell. They can be deleted in the next major release.
Other information: