Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

[AAE-12502] Fix ticketEcm is not added to the alf_ticket moving basic auth in ADF #1616

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

alep85
Copy link
Contributor

@alep85 alep85 commented Jul 21, 2023

…t in not added to the content api because config.ticketECM is undefined

Please check if the PR fulfills these requirements

[x] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-api/wiki/Commit-format)
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Moving basic auth in ADF Alfresco/alfresco-ng2-components#8689, the content authentication will be handled by the content-auth.ts and the e2e that open a file with the file-viewer failed because the alf_ticket is not added to the contentApi. Since the content-auth.ts can't update AlfrescoApiConfig, it's needed to get the ticketEcm from the Storage.

What is the new behavior?
The Storage is handled as Singleton, the instance is created by AlfrescoApi and the AlfrescoApiClient can access the Storage the ticketEcm https://github.com/Alfresco/alfresco-js-api/blob/dev-alepore-AAE-12502/src/alfrescoApiClient.ts#L246

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…t in not added to the content api because config.ticketECM is undefined
@eromano eromano merged commit 70e78e8 into develop Jul 21, 2023
7 checks passed
@eromano eromano deleted the dev-alepore-AAE-12502 branch July 21, 2023 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants