OPSEXP-2116 repository service named template alfresco-connector-ms365 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
approved these changes
Jul 10, 2023
gionn
requested changes
Jul 10, 2023
alxgomz
previously requested changes
Jul 10, 2023
There was a problem hiding this comment.
the nameOverride or fullnameOberride for the repo should be set by the parent chart.
I have tried that same approach of using override in subchart and figured out it has several drawback. It creates a lot of nesting, and doesn't play well with external components (where you would have the subchart's component disabled but still leverage the override underneeth it...
I think a better approach is to expect the parent chart to pass the repo URL details in a string (e.g. using the fullnameOverride passed in alfresco-connector-ms365.repository.host) and also support reading the repo details from an existing configmap (generated by the parent chart.
gionn
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.