OPSEXP-2743 Run ansible-galaxy via pipenv when available #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmacius
changed the title
gionn
requested changes
Jul 10, 2024
gionn
reviewed
Jul 11, 2024
Co-authored-by: Giovanni Toraldo <71768+gionn@users.noreply.github.com>
alxgomz
requested changes
Jul 11, 2024
There was a problem hiding this comment.
The PR mentions testing Pipfile presence but the code test the cache dir. I think neither are really safe (though I admit would work in most case) as:
Pipfile location can be given from env var & cache directory can be cleared using pipenv --clear and also set using env var.
Isn't it more simple to simply test the binary?
gionn
changed the title
gionn
approved these changes
Jul 11, 2024
alxgomz
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description