OPSEXP-1806 Fix multiline/markdown support in slack notification #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
force-pushed
the
OPSEXP-1806-slack-tests
branch
from
7a6ce89
to
c89f164
Compare
gionn
force-pushed
the
OPSEXP-1806-slack-tests
branch
from
c89f164
to
dea9301
Compare
|
|
alxgomz
approved these changes
Oct 25, 2022
| esac | ||
| fi | ||
|
|
||
| echo '' |
There was a problem hiding this comment.
what about removing the -n switch from echo commands and removing that empty echo ?
There was a problem hiding this comment.
it is to avoid having that last newline converted to \n by sed, while I really want a NL before the closing heredoc tag
echo "\nEOF" would have worked as well but for some reason looked less clear to me :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests
OPSEXP-1806