Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-1777 Fixup verify-helm action #144

Merged
merged 7 commits into from
Oct 14, 2022
Merged

OPSEXP-1777 Fixup verify-helm action #144

merged 7 commits into from
Oct 14, 2022

Conversation

gionn
Copy link
Member

@gionn gionn commented Oct 13, 2022 •
edited
Loading

  • have a different namespace when building a matrix, so parallelization is an option
  • increase retry timeout for test - to give more time to flaky things to settle up and for manual inspection
  • remove hard sleep before executing tests since we are already retrying them automatically
  • remove unnecessary cleanup in pods_ready function
  • bump ingress-nginx to version 4.2.5

OPSEXP-1777

@gionn gionn self-assigned this Oct 13, 2022
@pr-triage pr-triage bot added the PR: draft label Oct 13, 2022
@gionn gionn mentioned this pull request Oct 14, 2022
Merged
@gionn gionn changed the title Fixup verify-helm OPSEXP-1777 Fixup verify-helm cleanup phase Oct 14, 2022
@gionn gionn changed the title OPSEXP-1777 Fixup verify-helm cleanup phase OPSEXP-1777 Fixup verify-helm action Oct 14, 2022
@gionn gionn marked this pull request as ready for review October 14, 2022 07:08
@gionn gionn requested a review from alxgomz October 14, 2022 07:08
@gionn gionn requested a review from a team October 14, 2022 07:09
alxgomz
alxgomz reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one point

.github/actions/dbp-charts/verify-helm/helm_install.sh Show resolved Hide resolved
@gionn gionn requested a review from alxgomz October 14, 2022 09:46
@gionn gionn merged commit 38d9090 into master Oct 14, 2022
@gionn gionn deleted the fixup-helm-install branch October 14, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

Assignees

@gionn gionn

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gionn @alxgomz