OPSEXP-2147 Drop helper_modules role #956
Draft
+153
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
force-pushed
the
OPSEXP-2147-drop-helper-modules
branch
from
0de8a04
to
a271292
Compare
gionn
force-pushed
the
OPSEXP-2147-drop-helper-modules
branch
from
ea884e1
to
b26d244
Compare
alxgomz
requested changes
Oct 1, 2024
| checked_port: "{{ ports_cfg.sync.http }}" | ||
| delegate_target: "{{ groups.syncservice | first }}" | ||
| when: | ||
| - groups.syncservice | default([]) | length > 0 | ||
| - acs.edition == "Enterprise" |
There was a problem hiding this comment.
Why are you excluding the enterprise ersion condition for sync and adding it for ats?
There was a problem hiding this comment.
I think it's not really relevant in this context because syncservice group should be already empty when using community edition.
For transform it's different because tengine are deployed in both but only for the enterprise edition we need to check connectivity against trouter/activemq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPSEXP-2147