OPSEXP-1353 Deprecate Alfresco Sync Service HPA template #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxgomz
requested changes
Feb 1, 2023
helm/alfresco-content-services/charts/alfresco-sync-service/templates/hpa-syncservice.yaml
Show resolved
Hide resolved
upandey123
commented
Feb 1, 2023
No, you're looking at the wrong file. do not edit the Also you need to remove all values under hpa, not just |
|
As checked from my end all the HPA resources have been removed from the sync service. Should be good! |
gionn
requested changes
Feb 2, 2023
helm/alfresco-content-services/charts/alfresco-sync-service/values.yaml
Outdated
Show resolved
Hide resolved
gionn
approved these changes
Feb 3, 2023
gionn
changed the title
alxgomz
pushed a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync service is the only Chart that has some kind of autoscaling.
It is untested and leverage a now depreceated approach:
autoscaling/v2beta1 HorizontalPodAutoscaler is deprecated in v1.22+, unavailable in v1.25+; use autoscaling/v2beta2 HorizontalPodAutoscaler
Remove it from the subchart
Ref: OPSEXP-1353