Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-1651 Use existing secret to configure ACS postgres credentials #840

Merged
merged 6 commits into from
Jan 12, 2023
Merged

OPSEXP-1651 Use existing secret to configure ACS postgres credentials #840

merged 6 commits into from
Jan 12, 2023

Conversation

gionn
Copy link
Member

@gionn gionn commented Jan 5, 2023 •
edited
Loading

Ref: OPSEXP-1651

  • support existing secret for acs db
  • document support for existing secret in bitnami chart
  • add unit tests

@gionn gionn self-assigned this Jan 5, 2023
@pr-triage pr-triage bot added the PR: draft label Jan 5, 2023
@gionn gionn marked this pull request as ready for review January 5, 2023 14:14
@gionn gionn requested review from alxgomz and slohe1 January 5, 2023 14:14
alxgomz
alxgomz reviewed Jan 8, 2023
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, we could use envFrom to inject the whole secret

@gionn
Copy link
Member Author

gionn commented Jan 9, 2023

again, we could use envFrom to inject the whole secret

can't use envFrom because secret contain keys like DATABASE_PASSWORD while the container requires SPRING_DATASOURCE_PASSWORD

@gionn gionn requested a review from alxgomz January 9, 2023 09:13
@gionn gionn requested a review from alxgomz January 11, 2023 11:11
alxgomz
alxgomz previously approved these changes Jan 11, 2023
View reviewed changes
@gionn gionn enabled auto-merge (squash) January 12, 2023 08:47
@gionn gionn requested a review from alxgomz January 12, 2023 09:13
@gionn gionn merged commit 2d0b3e1 into master Jan 12, 2023
@gionn gionn deleted the OPSEXP-1651-dbsecret branch January 12, 2023 09:58
alxgomz pushed a commit that referenced this pull request Jan 23, 2024
@gionn @alxgomz
OPSEXP-1651 Use existing secret to configure ACS postgres credentials (…
e24d8fc 
…#840)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

@slohe1 slohe1 Awaiting requested review from slohe1

Assignees

@gionn gionn

Labels
PR: merged PR: partially-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gionn @alxgomz