Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-1796 Prepare chart versions for next iteration #812

Merged
merged 5 commits into from
Nov 17, 2022
Merged

OPSEXP-1796 Prepare chart versions for next iteration #812

merged 5 commits into from
Nov 17, 2022

Conversation

gionn
Copy link
Member

@gionn gionn commented Nov 16, 2022

@gionn gionn self-assigned this Nov 16, 2022
@gionn gionn requested a review from alxgomz November 17, 2022 08:05
alxgomz
alxgomz reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly the first publish try will fails on content-services chart as common will most likely be missing. Is the intention to just retry?

@gionn
Copy link
Member Author

gionn commented Nov 17, 2022

If I understand correctly the first publish try will fails on content-services chart as common will most likely be missing. Is the intention to just retry?

no, pre-commit and helm tests are fine thanks to use-local-deps, while publish of each chart is done sequentially and in the expected order. Apart from temporary glitches (like caching on github cdn side) everything should be fine.

@gionn gionn requested a review from alxgomz November 17, 2022 10:51
@alxgomz
Copy link
Contributor

alxgomz commented Nov 17, 2022

yes, when I say "likely to be missing" I'm referring to the caching behavior we saw yesterday.

@gionn gionn merged commit 1eb6126 into master Nov 17, 2022
@gionn gionn deleted the OPSEXP-1796-next-version branch November 17, 2022 11:05
alxgomz pushed a commit that referenced this pull request Jan 23, 2024
@gionn @alxgomz
OPSEXP-1796 Prepare chart versions for next iteration (#812)
46315fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

Assignees

@gionn gionn

Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gionn @alxgomz