Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-1717 Add Elasticsearch connector to docker-compose #769

Merged
merged 6 commits into from
Sep 14, 2022
Merged

OPSEXP-1717 Add Elasticsearch connector to docker-compose #769

merged 6 commits into from
Sep 14, 2022

Conversation

gionn
Copy link
Member

@gionn gionn commented Sep 12, 2022

OPSEXP-1717

Test with:

docker-compose -f docker-compose.yml -f elasticsearch-override-docker-compose.yml up -d

@pr-triage pr-triage bot added the PR: draft label Sep 12, 2022
@gionn gionn self-assigned this Sep 12, 2022
@gionn gionn requested a review from alxgomz September 12, 2022 09:26
@gionn gionn changed the title OPSEXP-1717 Test elasticsearch with override compose OPSEXP-1717 Elasticsearch for docker compose Sep 13, 2022
@gionn gionn marked this pull request as ready for review September 13, 2022 09:04
alxgomz
alxgomz requested changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're missing the reindex container (this one is not part of aio)

@gionn
Copy link
Member Author

gionn commented Sep 13, 2022

I think we're missing the reindex container (this one is not part of aio)

not sure 100% that it make sense to have it here (since we don't have persistence so we always start with a clean repo) but since it's not harming I think we can have it

@gionn gionn changed the title OPSEXP-1717 Elasticsearch for docker compose OPSEXP-1717 Add Elasticsearch connector to docker-compose Sep 13, 2022
@gionn gionn requested a review from alxgomz September 13, 2022 15:15
alxgomz
alxgomz approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gionn gionn merged commit e18a738 into master Sep 14, 2022
@gionn gionn deleted the OPSEXP-1717-es branch September 14, 2022 08:41
alxgomz pushed a commit that referenced this pull request Jan 23, 2024
@gionn @alxgomz
OPSEXP-1717 Add Elasticsearch connector to docker-compose (#769)
c609398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

Assignees

@gionn gionn

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gionn @alxgomz