Fix imagePullSecret handling when secret is not set #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello, would you mind fixing also for the future we really need to define a new template with that snippet and reuse everywhere |
…charts/alfresco-sync-service/templates/deployment-syncservice.yaml
|
Hi @gionn . I've made the same change to helm/alfresco-content-services/charts/alfresco-sync-service/templates/deployment-syncservice.yaml aswell! |
|
Looks like we have some issues on github actions for PR coming from forked repos, in the meanwhile I've manually run your code here so it's fine to merge. @dpmerron-ltd please sign the CLA and we can proceed to merge |
gionn
approved these changes
Aug 5, 2022
gionn
changed the title
|
Thanks for contributing! 🌮 |
alxgomz
pushed a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a helm upgrade over an existing deployment helm would error with;
client.go:205: [debug] error updating the resource "alfresco-content-services-alfresco-router":
failed to create patch: map: map[] does not contain declared merge key: name
upgrade.go:355: [debug] warning: Upgrade "alfresco-content-services" failed: failed to create patch: map: map[] does not contain declared merge key: name
This is because the original deployment would set the imagePullSecret to "name: " and would try to be re-set at upgrade. Since a blank value is defaulted in the chart values this conditional is needed in all the deployment (and is present in the others).