Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-1369 Add elasticsearch connector #693

Merged
merged 44 commits into from
May 6, 2022

Conversation

gionn
Copy link
Member

@gionn gionn commented Apr 13, 2022

@gionn gionn self-assigned this Apr 13, 2022
@pr-triage pr-triage bot added the PR: draft label Apr 13, 2022
@gionn gionn force-pushed the OPSEXP-1369-elasticsearch-connector branch 6 times, most recently from c549790 to aeb1614 Compare April 20, 2022 07:54
@gionn gionn marked this pull request as ready for review April 20, 2022 12:05
@gionn gionn force-pushed the OPSEXP-1369-elasticsearch-connector branch 2 times, most recently from d82909d to d0347b1 Compare April 20, 2022 12:41
@gionn gionn requested review from alxgomz and Mieszko96 April 20, 2022 12:43
@gionn gionn requested a review from mteodori April 21, 2022 07:49
@gionn gionn force-pushed the OPSEXP-1369-elasticsearch-connector branch from 3de4ec7 to dbfbd76 Compare April 21, 2022 14:57
@gionn gionn requested a review from alxgomz April 21, 2022 16:13
@gionn gionn force-pushed the OPSEXP-1369-elasticsearch-connector branch from f7737c4 to 55839c3 Compare April 22, 2022 07:49
@gionn gionn requested review from alxgomz and mteodori April 22, 2022 09:54
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last change which I don't think has any side effect

@gionn gionn force-pushed the OPSEXP-1369-elasticsearch-connector branch from c9e8c33 to cf41b9f Compare April 22, 2022 12:25
@gionn gionn requested a review from alxgomz April 22, 2022 13:13
.pre-commit-config.yaml Outdated Show resolved Hide resolved
helm/alfresco-content-services/Chart.yaml Outdated Show resolved Hide resolved
fail-fast: false
matrix:
acs_version: [ 6.2.N, 7.0.N, 7.1.N, community, latest ]
acs_version: [ latest, 7.1.N, 7.0.N, 6.2.N, community ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for changing the order here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since they are executed sequentially and now latest is the only one executing the persistence failover test (that I've disabled on the remaining jobs since it's slowing all the builds without really any added value), it's better to build latest first that is more comprehensive

image:
repositoryPrefix: quay.io/alfresco/alfresco-elasticsearch
pullPolicy: IfNotPresent
tag: "3.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no quotes to be consistent with other tags

@@ -0,0 +1,57 @@
image:
repositoryPrefix: quay.io/alfresco/alfresco-elasticsearch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use explicit repository and tag variables per each image in order to keep FluxCD happy without extra configuration

@gionn gionn force-pushed the OPSEXP-1369-elasticsearch-connector branch from f2bbc54 to cd481e2 Compare April 26, 2022 13:51
@gionn gionn requested review from mteodori and jesty April 26, 2022 14:32
- name: elasticsearch
alias: elasticsearch
repository: https://helm.elastic.co
version: 7.10.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesty check, is there a newer tested version?

@gionn gionn merged commit 09363cc into master May 6, 2022
@gionn gionn deleted the OPSEXP-1369-elasticsearch-connector branch May 6, 2022 09:27
alxgomz pushed a commit that referenced this pull request Jan 23, 2024
* add alfresco-content-common subchart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants