Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACS-1870: add new MS Teams option #582

Merged
merged 3 commits into from
Aug 24, 2021
Merged

ACS-1870: add new MS Teams option #582

merged 3 commits into from
Aug 24, 2021

Conversation

montgolfiere
Copy link
Contributor

@montgolfiere montgolfiere commented Aug 23, 2021 •
edited
Loading

  • passed pre-commit hooks
  • sanity checked ms-teams-service pod startup (in local k8s)
  • note: will fully test in https pipeline env

@montgolfiere
ACS-1870: Initial commit for MS Teams option / example (WIP)
285d260 
- passed pre-commit hooks
- note: WIP - not yet tested
@pr-triage pr-triage bot added the PR: draft label Aug 23, 2021
@montgolfiere montgolfiere mentioned this pull request Aug 23, 2021
Closed
@montgolfiere
ACS-1870: Initial commit for MS Teams option / example
db8e610 
- sanity checked pod startup in local k8s
@montgolfiere montgolfiere changed the title ACS-1870: Initial commit for MS Teams option / example (WIP) ACS-1870: New MS Teams option Aug 24, 2021
@montgolfiere montgolfiere marked this pull request as ready for review August 24, 2021 08:37
@montgolfiere montgolfiere changed the title ACS-1870: New MS Teams option ACS-1870: add new MS Teams option Aug 24, 2021
@montgolfiere
ACS-1870: Initial commit for MS Teams option / example
be9395d 
- update README (using pre-commit run -a)
PunchedChimera
PunchedChimera approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@PunchedChimera PunchedChimera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aymanthefirst
aymanthefirst approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@aymanthefirst aymanthefirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and we saw it working via a screen share session.

@montgolfiere montgolfiere merged commit d5b3047 into master Aug 24, 2021
@montgolfiere montgolfiere deleted the feature/ACS-1870_helm_option_for_new_ms_teams_int branch August 24, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KikoUK KikoUK KikoUK approved these changes

@mpichura mpichura mpichura approved these changes

@aymanthefirst aymanthefirst aymanthefirst approved these changes

@PunchedChimera PunchedChimera PunchedChimera approved these changes

@mteodori mteodori Awaiting requested review from mteodori

@TheOutsSeeker TheOutsSeeker Awaiting requested review from TheOutsSeeker

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@montgolfiere @KikoUK @mpichura @aymanthefirst @PunchedChimera