Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2391 Document how to provision with an external keycloak #1091

Merged
merged 6 commits into from
Feb 14, 2024
Merged

OPSEXP-2391 Document how to provision with an external keycloak #1091

merged 6 commits into from
Feb 14, 2024

Conversation

gionn
Copy link
Member

@gionn gionn commented Feb 13, 2024

@gionn gionn self-assigned this Feb 13, 2024
@gionn gionn marked this pull request as ready for review February 13, 2024 15:24
@gionn gionn requested a review from alxgomz February 14, 2024 08:04
alxgomz
alxgomz approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of introducing that new config key but tbh I have no better idea

@gionn gionn merged commit 83becc7 into master Feb 14, 2024
18 checks passed
@gionn gionn deleted the OPSEXP-2391-external-keycloak branch February 14, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

@pmacius pmacius Awaiting requested review from pmacius

Assignees

@gionn gionn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gionn @alxgomz