Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2439 Helm test with dtas #1080

Merged
merged 47 commits into from
Feb 2, 2024
Merged

OPSEXP-2439 Helm test with dtas #1080

merged 47 commits into from
Feb 2, 2024

Conversation

gionn
Copy link
Member

@gionn gionn commented Jan 23, 2024

@gionn gionn self-assigned this Jan 23, 2024
test/enterprise-integration-test-values.yaml Outdated Show resolved Hide resolved
test/enterprise-integration-test-values.yaml Outdated Show resolved Hide resolved
test/enterprise-integration-test-values.yaml Outdated Show resolved Hide resolved
.github/workflows/helm-enterprise.yml Outdated Show resolved Hide resolved
.github/workflows/helm-enterprise.yml Outdated Show resolved Hide resolved
.github/workflows/helm-enterprise.yml Outdated Show resolved Hide resolved
@gionn gionn requested a review from alxgomz January 25, 2024 16:25
@gionn gionn marked this pull request as ready for review January 26, 2024 09:36
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of having test related info in values file.
I'd rather we have these in separate value files under the test folder

@gionn
Copy link
Member Author

gionn commented Jan 29, 2024

I'd rather we have these in separate value files under the test folder

I was already thinking that eventually we'll make dtas public and could really be run by default upon installs, so it's better that is part of the default values file.

On another side note, I am not really sure that explicitly checking installed versions as part of DTAS really bring some value, the main objective should be to verify the everything is behaving correctly, and not that a version I've written in yaml file is the same I've written in another yaml file 😀

@gionn gionn requested a review from alxgomz January 29, 2024 09:39
.github/workflows/helm-enterprise.yml Outdated Show resolved Hide resolved
helm/alfresco-content-services/values.yaml Outdated Show resolved Hide resolved
@gionn gionn requested a review from alxgomz February 2, 2024 14:50
@gionn gionn merged commit c1bd8b9 into master Feb 2, 2024
18 checks passed
@gionn gionn deleted the OPSEXP-2439-dtas-test branch February 2, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants