Skip to content

Commit

Permalink
revierw comments
Browse files Browse the repository at this point in the history
  • Loading branch information
alxgomz committed Jun 6, 2024
1 parent 4a6cb82 commit a72d918
Show file tree
Hide file tree
Showing 10 changed files with 31 additions and 31 deletions.
2 changes: 1 addition & 1 deletion docs/helm/autoscaling.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ In the same maner the parameters below can be set:

Refer to the
[alfresco-repository auto-scaling
documentation](https://github.com/Alfresco/alfresco-helm-charts/blob/main/charts/alfresco-transform-service/docs/autoscaling.md)
documentation](https://alfresco.github.io/alfresco-helm-charts/charts/alfresco-transform-service/docs/autoscaling.html)
for a detailed guide on Alfresco repository auto-scaling configuration and
implications.

Expand Down
60 changes: 30 additions & 30 deletions helm/alfresco-content-services/tests/keda_test.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
suite: test KEDA scalers
templates:
- keda-scaler-activemq-ats-im.yaml
- keda-scaler-activemq-ats-lo.yaml
- keda-scaler-activemq-ats-misc.yaml
- keda-scaler-activemq-ats-pdf.yaml
- keda-scaler-activemq-ats-tika.yaml
- keda/scaler-activemq-ats-im.yaml
- keda/scaler-activemq-ats-lo.yaml
- keda/scaler-activemq-ats-misc.yaml
- keda/scaler-activemq-ats-pdf.yaml
- keda/scaler-activemq-ats-tika.yaml
tests:
- it: should render individual scalers all based on embded ActiveMQ and apssed values
values:
Expand All @@ -14,43 +14,43 @@ tests:
- equal:
path: spec.scaleTargetRef.name
value: RELEASE-NAME-imagemagick
template: keda-scaler-activemq-ats-im.yaml
template: keda/scaler-activemq-ats-im.yaml
- equal:
path: spec.scaleTargetRef.name
value: RELEASE-NAME-libreoffice
template: keda-scaler-activemq-ats-lo.yaml
template: keda/scaler-activemq-ats-lo.yaml
- equal:
path: spec.scaleTargetRef.name
value: RELEASE-NAME-transform-misc
template: keda-scaler-activemq-ats-misc.yaml
template: keda/scaler-activemq-ats-misc.yaml
- equal:
path: spec.scaleTargetRef.name
value: RELEASE-NAME-pdfrenderer
template: keda-scaler-activemq-ats-pdf.yaml
template: keda/scaler-activemq-ats-pdf.yaml
- equal:
path: spec.scaleTargetRef.name
value: RELEASE-NAME-tika
template: keda-scaler-activemq-ats-tika.yaml
template: keda/scaler-activemq-ats-tika.yaml
- equal:
path: spec.triggers[0].metadata.destinationName
value: org.alfresco.transform.engine.imagemagick.acs
template: keda-scaler-activemq-ats-im.yaml
template: keda/scaler-activemq-ats-im.yaml
- equal:
path: spec.triggers[0].metadata.destinationName
value: org.alfresco.transform.engine.libreoffice.acs
template: keda-scaler-activemq-ats-lo.yaml
template: keda/scaler-activemq-ats-lo.yaml
- equal:
path: spec.triggers[0].metadata.destinationName
value: org.alfresco.transform.engine.misc.acs
template: keda-scaler-activemq-ats-misc.yaml
template: keda/scaler-activemq-ats-misc.yaml
- equal:
path: spec.triggers[0].metadata.destinationName
value: org.alfresco.transform.engine.alfresco-pdf-renderer.acs
template: keda-scaler-activemq-ats-pdf.yaml
template: keda/scaler-activemq-ats-pdf.yaml
- equal:
path: spec.triggers[0].metadata.destinationName
value: org.alfresco.transform.engine.tika.acs
template: keda-scaler-activemq-ats-tika.yaml
template: keda/scaler-activemq-ats-tika.yaml
- equal:
path: spec.triggers[0].metadata.managementEndpoint
value: RELEASE-NAME-activemq-web-console.NAMESPACE.svc:8161
Expand All @@ -60,58 +60,58 @@ tests:
- equal:
path: spec.idleReplicaCount
value: 0
template: keda-scaler-activemq-ats-lo.yaml
template: keda/scaler-activemq-ats-lo.yaml
- notExists:
path: spec.idleReplicaCount
template: keda-scaler-activemq-ats-im.yaml
template: keda/scaler-activemq-ats-im.yaml
- equal:
path: spec.pollingInterval
value: 90
template: keda-scaler-activemq-ats-misc.yaml
template: keda/scaler-activemq-ats-misc.yaml
- equal:
path: spec.pollingInterval
value: 15
template: keda-scaler-activemq-ats-lo.yaml
template: keda/scaler-activemq-ats-lo.yaml
- equal:
path: spec.initialCooldownPeriod
value: 600
template: keda-scaler-activemq-ats-lo.yaml
template: keda/scaler-activemq-ats-lo.yaml
- equal:
path: spec.initialCooldownPeriod
value: 300
template: keda-scaler-activemq-ats-im.yaml
template: keda/scaler-activemq-ats-im.yaml
- equal:
path: spec.cooldownPeriod
value: 900
template: keda-scaler-activemq-ats-lo.yaml
template: keda/scaler-activemq-ats-lo.yaml
- notExists:
path: spec.cooldownPeriod
template: keda-scaler-activemq-ats-im.yaml
template: keda/scaler-activemq-ats-im.yaml
- equal:
path: spec.cooldownPeriod
value: 3600
template: keda-scaler-activemq-ats-misc.yaml
template: keda/scaler-activemq-ats-misc.yaml
- equal:
path: spec.minReplicaCount
value: 1
template: keda-scaler-activemq-ats-im.yaml
template: keda/scaler-activemq-ats-im.yaml
- equal:
path: spec.minReplicaCount
value: 3
template: keda-scaler-activemq-ats-pdf.yaml
template: keda/scaler-activemq-ats-pdf.yaml
- equal:
path: spec.maxReplicaCount
value: 3
template: keda-scaler-activemq-ats-im.yaml
template: keda/scaler-activemq-ats-im.yaml
- equal:
path: spec.maxReplicaCount
value: 9
template: keda-scaler-activemq-ats-tika.yaml
template: keda/scaler-activemq-ats-tika.yaml
- equal:
path: spec.triggers[0].metadata.targetQueueSize
value: "10"
template: keda-scaler-activemq-ats-im.yaml
template: keda/scaler-activemq-ats-im.yaml
- equal:
path: spec.triggers[0].metadata.targetQueueSize
value: "50"
template: keda-scaler-activemq-ats-tika.yaml
template: keda/scaler-activemq-ats-tika.yaml

0 comments on commit a72d918

Please sign in to comment.