Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jakarta-migrated community-repo #1526

Merged
merged 31 commits into from
Aug 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b0ff829
use jakarta-migrated community-repo
SaraAspery Jul 6, 2023
b64c3bd
Merge branch 'master' into jakarta-migration
SaraAspery Jul 6, 2023
6e90ba1
use jakarta-migrated community-repo and community-share
SaraAspery Jul 7, 2023
a5fdd2f
build jakarta dependencies for community-repo
SaraAspery Jul 7, 2023
9e8d1a0
temporarily do not build share
SaraAspery Jul 7, 2023
511b16a
fix parent pom version
SaraAspery Jul 7, 2023
752b6dd
use -force option to fix docker image build failures
SaraAspery Jul 7, 2023
96655f3
trigger build
SaraAspery Jul 7, 2023
0492067
use correct versions of community-share and acs-packaging
SaraAspery Jul 7, 2023
9dc02c9
update community-repo version
SaraAspery Jul 11, 2023
4e9603f
Use released share zip
pzhyland Jul 11, 2023
6f842a9
Bump cargo-maven3-plugin tomcat version from 9x to 10x
SaraAspery Jul 11, 2023
aafd91e
revert to Tomcat9x
SaraAspery Jul 11, 2023
67fc86d
bump community-repo from 161-SNAPSHOT to 163-SNAPSHOT
SaraAspery Jul 12, 2023
f8efb7d
Bump cargo-maven3-plugin tomcat version from 9x to 10x
SaraAspery Jul 12, 2023
bf23e01
Minor changes to tomcat deployment test
SaraAspery Jul 14, 2023
0c8174b
Merge branch 'master' into jakarta-migration
SaraAspery Jul 14, 2023
53e6f33
Bump community-repo from 163-SNAPSHOT to 164-SNAPSHOT
SaraAspery Jul 14, 2023
084a5da
Include Tomcat deployment test as condition for docker images update
SaraAspery Jul 14, 2023
6f73419
Merge branch 'master' into jakarta-migration. Update comm-repo versio…
SaraAspery Jul 25, 2023
c01ba33
Changes to community_test_tomcat_deployment
SaraAspery Jul 25, 2023
2c010c5
Correct community-repo version
SaraAspery Jul 26, 2023
ea78fca
Bump community-repo version to 23.1.0.170-SNAPSHOT
SaraAspery Jul 26, 2023
96e2cdb
Merge branch 'master' into jakarta-migration
kmagdziarz Aug 10, 2023
dbe413c
Pin acs-packaging version to A27 for share compatibility
SaraAspery Aug 10, 2023
bd88b28
Workaround for not migrated share
SaraAspery Aug 10, 2023
64f401b
Disable Tomcat deployment test
SaraAspery Aug 10, 2023
b7d2a43
Update latest docker images no longer relies on tomcat deployment test
SaraAspery Aug 10, 2023
a7d1d2b
As per [ACS-5545] -force flag should not be needed
kmagdziarz Aug 11, 2023
39626ee
Remove jakarta-dependencies build from script
SaraAspery Aug 11, 2023
0d85c6a
Merge remote-tracking branch 'origin/jakarta-migration' into jakarta-…
SaraAspery Aug 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 31 additions & 26 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,32 +116,37 @@ jobs:
- name: "Clean Maven cache"
run: bash ./scripts/ci/cleanup_cache.sh

community_test_tomcat_deployment:
name: "Test Tomcat deployment"
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[skip tests]')"
steps:
- uses: actions/checkout@v3
- uses: Alfresco/alfresco-build-tools/.github/actions/get-build-info@v1.33.0
- uses: Alfresco/alfresco-build-tools/.github/actions/setup-java-build@v1.33.0
- name: "Init"
timeout-minutes: ${{ fromJSON(env.GITHUB_ACTIONS_DEPLOY_TIMEOUT) }}
run: |
bash ./scripts/ci/init.sh
bash ./scripts/ci/build.sh
- name: "Set up the environment"
run: |
${TAS_SCRIPTS}/start-compose.sh ./dev/docker-compose.yml
${TAS_SCRIPTS}/wait-for-alfresco-start.sh "http://localhost:8983/solr"
- name: "Run tomcat, verify it starts"
id: tests
run: |
(mvn clean install -Prun -rf dev &)
${TAS_SCRIPTS}/wait-for-alfresco-start.sh "http://localhost:8080/alfresco/"
echo "Test Alfresco Repository availability"
curl -Ls -o /dev/null --fail "http://localhost:8080/alfresco"
echo "Test Share availability"
curl -Ls -o /dev/null --fail "http://localhost:8080/share"
#https://alfresco.atlassian.net/browse/ACS-5832
# community_test_tomcat_deployment:
# name: "Test Tomcat deployment"
# runs-on: ubuntu-latest
# if: >
# !contains(github.event.head_commit.message, '[skip tests]')
# steps:
# - uses: actions/checkout@v3
# with:
# persist-credentials: false
# - uses: Alfresco/alfresco-build-tools/.github/actions/get-build-info@v1.35.2
# - uses: Alfresco/alfresco-build-tools/.github/actions/free-hosted-runner-disk-space@v1.35.2
# - uses: Alfresco/alfresco-build-tools/.github/actions/setup-java-build@v1.35.2
# - name: "Build"
# timeout-minutes: ${{ fromJSON(env.GITHUB_ACTIONS_DEPLOY_TIMEOUT) }}
# run: |
# bash ./scripts/ci/init.sh
# bash ./scripts/ci/build.sh
# - name: "Set up the environment"
# run: |
# ${TAS_SCRIPTS}/start-compose.sh ./dev/docker-compose.yml
# ${TAS_SCRIPTS}/wait-for-alfresco-start.sh "http://localhost:8983/solr"
# - name: "Run tomcat, verify it starts"
# id: tests
# run: |
# (mvn clean install -Prun -rf dev &)
# ${TAS_SCRIPTS}/wait-for-alfresco-start.sh "http://localhost:8080/alfresco/"
# echo "Test Alfresco Repository availability"
# curl -Ls -o /dev/null --fail "http://localhost:8080/alfresco"
# echo "Test Share availability"
# curl -Ls -o /dev/null --fail "http://localhost:8080/share"

docker_latest:
name: Update latest Docker images
Expand Down
2 changes: 1 addition & 1 deletion dev/dev-acs-amps-overlay/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<artifactId>cargo-maven3-plugin</artifactId>
<configuration>
<container>
<containerId>tomcat9x</containerId>
<containerId>tomcat10x</containerId>
<type>embedded</type>
<log>target/cargo.log</log>
<systemProperties>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<properties>
<dependency.alfresco-community-repo.version>23.1.0.187</dependency.alfresco-community-repo.version>
<dependency.alfresco-community-share.version>23.1.0.190</dependency.alfresco-community-share.version>
<dependency.acs-packaging.version>23.1.0-A28</dependency.acs-packaging.version> <!-- for Share distribution zip -->
<dependency.acs-packaging.version>23.1.0-A27</dependency.acs-packaging.version> <!-- for Share distribution zip -->

<repo.image.tag>${dependency.alfresco-community-repo.version}</repo.image.tag>
<share.image.tag>${dependency.alfresco-community-share.version}</share.image.tag>
Expand Down
15 changes: 13 additions & 2 deletions scripts/ci/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,20 @@ fi
SHARE_UPSTREAM_REPO="github.com/Alfresco/alfresco-community-share.git"
# Checkout the upstream share project (tag or branch; + build if the latter)
if [[ "${SHARE_DEPENDENCY_VERSION}" =~ ^.+-SNAPSHOT$ ]] ; then
pullAndBuildSameBranchOnUpstream "${SHARE_UPSTREAM_REPO}" "-P$BUILD_PROFILE -Pags -Dlicense.failOnNotUptodateHeader=true -Ddocker.quay-expires.value=NEVER ${REPO_IMAGE} -Ddependency.alfresco-community-repo.version=${COM_DEPENDENCY_VERSION}"
pullAndBuildSameBranchOnUpstream "${SHARE_UPSTREAM_REPO}" "-P$BUILD_PROFILE -Pags -Dlicense.failOnNotUptodateHeader=true -Ddocker.quay-expires.value=NEVER ${REPO_IMAGE}"
else
pullUpstreamTagAndBuildDockerImage "${SHARE_UPSTREAM_REPO}" "${SHARE_DEPENDENCY_VERSION}" "-P$BUILD_PROFILE -Pags -Dlicense.failOnNotUptodateHeader=true -Ddocker.quay-expires.value=NEVER -Ddependency.alfresco-community-repo.version=${COM_DEPENDENCY_VERSION}"
# To handle corresponding problem in acs-packaging https://alfresco.atlassian.net/browse/ACS-5820
pullUpstreamTag "${SHARE_UPSTREAM_REPO}" "${SHARE_DEPENDENCY_VERSION}"

docker images

git clone -b "${SHARE_DEPENDENCY_VERSION}" --depth=1 "https://${GIT_USERNAME}:${GIT_PASSWORD}@${SHARE_UPSTREAM_REPO}" /tmp/commrepo
mvn -f /tmp/commrepo/pom.xml -B -ntp -V clean package -DskipTests -Dmaven.javadoc.skip=true "-Dimage.tag=${SHARE_DEPENDENCY_VERSION}" "-P$BUILD_PROFILE" -Pags -Dlicense.failOnNotUptodateHeader=true

docker images

buildUpstreamTag "${SHARE_UPSTREAM_REPO}" "${SHARE_DEPENDENCY_VERSION}" "-P$BUILD_PROFILE -Pags -Dlicense.failOnNotUptodateHeader=true -Ddocker.quay-expires.value=NEVER"
#pullUpstreamTagAndBuildDockerImage "${SHARE_UPSTREAM_REPO}" "${SHARE_DEPENDENCY_VERSION}" "-P$BUILD_PROFILE -Pags -Dlicense.failOnNotUptodateHeader=true -Ddocker.quay-expires.value=NEVER -Ddependency.alfresco-community-repo.version=${COM_DEPENDENCY_VERSION}"
fi

# Build the current project
Expand Down