Add destroyOnHide for DialogService pubSub payloads #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration property to payloads for DialogService pubSub events to create dialog instances to specify
destroyOnHidesemantics.Currently, all dialogs created via the DialogService will remain technically alive and active until the next dialog with the same
dialogIdis created and any previous instance is properly destroyed. For complex dialogs that include widgets with active pubSub interactions this means these widgets may continue to publish or react to events. E.g. in the OOTBee Support Tools addon there is a dialog to display and contiuously reload the alfresco.log / share.log files, refreshing on a timer. Currently, the timer keeps triggering after the dialog is closed (hidden) as it and its widgets are not eagerly destroyed. AdestroyOnHideproperty and eager widget destruction addresses this use case.