Locale generalization so JS_LOCALE of de_DE results in use of de #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| config.language = locale; | ||
|
|
||
| config.language = locale || bestGeneralizedLocale || 'en'; |
There was a problem hiding this comment.
We have JSHint on our build servers to use double rather than single quotes (the build aggressively fails on JSHint errors!). I'm flagging this up for future reference more than anything else as I'm happy to merge myself and then fix the build failure. But if it's simple enough for you to push a quick update then I'd be very grateful.
|
Thanks for recreating this PR...I've made one minor comment on our preferred JSHint configuration, but otherwise I'm happy to merge this having tested it out locally. |
|
Thanks for making that update so quickly - I've now merged the request. It will be in the 1.0.79 release which will either be later this week or early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreation of #1168
The languages supported by TinyMCE editor are maintained as two-letter country codes while the JS_LOCALE will typically be the combination of country and language code, i.e. de_DE. The current locale matching in the TinyMCE editor does not detect / select an available, generalized locale and essentially always falls back to English.
This PR adds locale generalization checks during in the locale match code of the TinyMCE editor.