Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time format issue with ngx-timepicker-field #211

Closed
Dona278 opened this issue Sep 12, 2019 · 9 comments
Closed

Time format issue with ngx-timepicker-field #211

Dona278 opened this issue Sep 12, 2019 · 9 comments

Comments

@Dona278
Copy link

Dona278 commented Sep 12, 2019

I have different issues with ngx-timepicker-field and 24 format:

  • If I set a time like "07:25" the input shows "7:25":
    image
    then if I blur the input it shows correct value:
    image
  • If I set a time like "07:00" the input not shows "00":
    image
@Agranom
Copy link
Owner

Agranom commented Sep 18, 2019

I'll check

@Dona278
Copy link
Author

Dona278 commented Sep 21, 2019

Hi @Agranom! Have you news about this issue? Thanx

@Agranom
Copy link
Owner

Agranom commented Sep 21, 2019

Hi. Yes. I’m preparing a bunch of fixes. So it will be fixed in the nearest release (~in a week)

@Agranom
Copy link
Owner

Agranom commented Oct 5, 2019

I believe it's fixed. Update to v5.2.0

@Agranom Agranom closed this as completed Oct 5, 2019
@Dona278
Copy link
Author

Dona278 commented Oct 7, 2019

Hi @Agranom, unfortunately the more serious issue isn't fixed. The format of the time with one digit (the first point of this issue) seems to be correct because even if I write / choose the time and then I blur the input the displayed value remain the same.
The second point of the issue still persist:
display_value_error

@Agranom Agranom reopened this Oct 7, 2019
@Agranom
Copy link
Owner

Agranom commented Oct 7, 2019

I see. Will check it

Agranom added a commit that referenced this issue Oct 12, 2019
* issue211: ! updating hour and minute without clock interaction

* fix(append-to-input): change method type from private to public
@Agranom
Copy link
Owner

Agranom commented Oct 12, 2019

Fixed. Check it pls

@Dona278
Copy link
Author

Dona278 commented Oct 14, 2019

@Agranom perfect thank you!
Now there is only one imperfection: it shows "12" and "0" correctly but minutes shows only 1 digit
image
If I blurred the input it shows "00"
image
Would you like that I open a new issue?

@Agranom
Copy link
Owner

Agranom commented Oct 14, 2019

Yes, please. Create a new issue, I'll close this one

@Agranom Agranom closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants