Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] 12 hr format, fully disabled clockface displayed when minimum is around PM hours and no value selected yet. #202

Closed
igalklebanov opened this issue Sep 10, 2019 · 1 comment

Comments

@igalklebanov
Copy link
Contributor

Current situation: selection modal just opens with a fully disabled hours clockface. User has to change to PM manually just to be able to select hour.

Expected behavior: open modal with PM hours clockface when min is around PM hours and there's no value selected already.

Bug repro:
min = 3:00 PM
value = undefined
-> open selection modal

Agranom added a commit that referenced this issue Sep 11, 2019
* issue130: + append timepicker to body

* * changelog and version

* issue203: + set provided min time as the default time if no value is provided

* issue204: + configurable style props for editable dial

* issue200: + custom buttons for ngx-timepicker-field

* issue203: + tests for fromDateTimeToString fn

* issue203: + tests for setting min time as a default one

* * changelog and version
@Agranom
Copy link
Owner

Agranom commented Sep 11, 2019

Done (v5.1.0)

@Agranom Agranom closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants