Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faucet Polling in E2E Tests #191

Merged
merged 25 commits into from
Sep 11, 2024
Merged

Faucet Polling in E2E Tests #191

merged 25 commits into from
Sep 11, 2024

Conversation

usmanmani1122
Copy link
Contributor

@usmanmani1122 usmanmani1122 commented Aug 29, 2024 •
edited
Loading

Description

Updated test to poll for transaction completion

@usmanmani1122 usmanmani1122 self-assigned this Aug 29, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 29, 2024 •
edited
Loading

Deploying wallet-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6e27ea3
Status: ✅  Deploy successful!
Preview URL: https://ad755db3.wallet-app.pages.dev
Branch Preview URL: https://usman-faucet-polling.wallet-app.pages.dev

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Cloudflare deployment logs are available here

@usmanmani1122 usmanmani1122 changed the title Faucet Polling Faucet Polling in E2E Tests Sep 11, 2024
@usmanmani1122 usmanmani1122 marked this pull request as ready for review September 11, 2024 12:47
Muneeb147
Muneeb147 reviewed Sep 11, 2024
View reviewed changes
Copy link

@Muneeb147 Muneeb147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are package upgrades changes intended? eslint-plugin-jsdoc -> 43.0.8?
Rest looks good. Just curious about changes in yarn.lock. If all those are intended then that's fine.

@usmanmani1122
Copy link
Contributor Author

Are package upgrades changes intended? eslint-plugin-jsdoc -> 43.0.8? Rest looks good. Just curious about changes in yarn.lock. If all those are intended then that's fine.

Yes
The updgrades are done to support Node 20

@usmanmani1122 usmanmani1122 merged commit 1207eaa into main Sep 11, 2024
4 of 6 checks passed
@usmanmani1122 usmanmani1122 deleted the usman/faucet-polling branch September 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Muneeb147 Muneeb147 Muneeb147 approved these changes

@rabi-siddique rabi-siddique Awaiting requested review from rabi-siddique

Assignees

@usmanmani1122 usmanmani1122

Labels
emerynet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmanmani1122 @Muneeb147