URL changes in e2e tests to make it work locally #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying wallet-app with
|
| Latest commit: |
14d454c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2b9d9142.wallet-app.pages.dev |
| Branch Preview URL: | https://rs-fix-local-e2e-tests.wallet-app.pages.dev |
|
Cloudflare deployment logs are available here |
rabi-siddique
force-pushed
the
rs-fix-local-e2e-tests
branch
from
0ac6128
to
14d454c
Compare
rabi-siddique
changed the title
Muneeb147
reviewed
Aug 28, 2024
| @@ -19,15 +19,15 @@ describe('Wallet App Test Cases', { execTimeout: DEFAULT_EXEC_TIMEOUT }, () => { | |||
| }); | |||
| }); | |||
| it(`should open the web wallet URL successfully`, () => { | |||
| cy.visit(`${userConfig.webwalletURL}`); | |||
| cy.visit('/'); | |||
There was a problem hiding this comment.
Shouldn't we do it conditionally wheb AGORIC_NET is local?
There was a problem hiding this comment.
All networks should use localhost:3000 for testing. Previously, all networks used localhost:3000 except when AGORIC_NET was set to local, in which case https://wallet.agoric.app/ was used. You can see this in the webWalletURL parameter here.
|
Looks like E2E tests are passing with Only the test case related to viewing bids from CLI is failing. It fails with most networks except |
frazarshad
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the
sesversion in #187, thea3pchain is working fine with the wallet app. This PR updates the e2e tests to use thelocalhostURL whenAGORIC_NETislocal.closes #184